[PLATFORM-863]: Improve code coverage test for error messages in Veil #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiemontese
requested review from
Fs00 and
cpiemontese
and removed request for
cpiemontese
cpiemontese
reviewed
Dec 16, 2022
veil-macros/src/redact.rs
Outdated
| if unused.should_throw_err() { | ||
| return Err(syn::Error::new( | ||
| item_span, | ||
| "`#[derive(Redact)]` does nothing by default, you must specify at least one field to redact. You should `#[derive(Debug)]` instead if this is intentional", |
There was a problem hiding this comment.
This doesn't seem to be tested, or am I missing something?
There was a problem hiding this comment.
It's tested in redact_unused.rs 😁
|
I like the overall refactor 😄 |
MaeIsBad
previously approved these changes
Dec 19, 2022
WilliamVenner
force-pushed
the
PLATFORM-863/user-story/improve-code-coverage-test-for-error-messages-in-veil
branch
from
67fe5af to
628b654
Compare
|
@MaeIsBad Had to rebase D: |
MaeIsBad
approved these changes
Dec 20, 2022
WilliamVenner
deleted the
PLATFORM-863/user-story/improve-code-coverage-test-for-error-messages-in-veil
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-863
This PR introduces a change to the code coverage test for error messages that catches a instances of syn::Error::new_spanned.
I have also added the missing tests to improve the said code coverage.