-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATFORM-833]: Add a way of using the Display implementation instead of the Debug implementation when redacting #58
Conversation
68305f6
to
654faab
Compare
Could you add some tests that include macro invocation with |
@oliverbrowneprima Uhh yeah is the test in redaction_tests.rs not enough? |
I'd prefer, for the sake of avoiding regressions in the future, if there was also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, I agree on adding a few more test cases which capture how we expect this to behave
…nse places in enums
Cheers guys, caught somewhere where |
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-833
This PR implements the
#[redact(display)]
option which allows the user to override which format implementation is chosen to redact.This allows users to choose redacting the output of a type's
std::fmt::Display
implementation where they feel is appropriate.Relevant Slack discussion https://prima.slack.com/archives/C01C70U9F37/p1670860264520579