Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: margin and disable buttons for invalid forms #57

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

krithika7402
Copy link
Collaborator

@krithika7402 krithika7402 commented Feb 28, 2025

Description

  • Margin and disable buttons for invalid forms
  • Spacing issue between the buttons

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • I have reviewed contributor guidelines

Screenshots

image image

Additional Notes

Copy link

changeset-bot bot commented Feb 28, 2025

πŸ¦‹ Changeset detected

Latest commit: 3ec6e43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
specif-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@tdeepak-presidio tdeepak-presidio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinion but something i generally follow is to use gap for spacing items in a flex container.

anand-presidio
anand-presidio previously approved these changes Feb 28, 2025
@krithika7402
Copy link
Collaborator Author

I don't have strong opinion but something i generally follow is to use gap for spacing items in a flex container.

Thanks for the pointer! Updated the PR now.

@anand-presidio anand-presidio merged commit c459076 into presidio-oss:main Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants