Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring suggestions for AI Chat #23

Merged

Conversation

krithika7402
Copy link
Collaborator

@krithika7402 krithika7402 commented Feb 18, 2025

Recurring suggestions for AI Chat

Changes:

  • Added recurring suggestions
  • Regenerate suggestions while description gets updated
  • Auto scroll down after suggestions are generated

recurring-suggestions

Copy link
Collaborator

@anand-presidio anand-presidio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tdeepak-presidio tdeepak-presidio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is we are instructing LLM to not suggest all the previously suggested suggestions.

What could be the pros/ cons of not suggesting just the selected suggestions and not all previously suggested suggestions? as there could be valuable suggestions there/ user was not able to select since only one can be selected at a time.

@krithika7402
Copy link
Collaborator Author

krithika7402 commented Feb 18, 2025

Hey @tdeepak-presidio , since users pick what's most relevant to them, we focus on moving forward with fresh suggestions. But you make a good point - we could always add a way to revisit previous suggestions if it becomes helpful.

@krithika7402 krithika7402 merged commit 2470f39 into presidio-oss:main Feb 18, 2025
@krithika7402 krithika7402 deleted the feat/recurring-suggestions branch February 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants