Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes circular require warning #1363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kbrock
Copy link

@kbrock kbrock commented Sep 27, 2024

fixes:

warning: lib/prawn/fonts.rb:9: warning: loading in progress, circular require considered harmful - lib/prawn/font.rb

Aah.

Fixes: #1349

@radwo
Copy link

radwo commented Mar 7, 2025

Hey team!

Any idea if this is going to be merge?

Verified

This commit was signed with the committer’s verified signature.
kbrock Keenan Brock
warning: lib/prawn/fonts.rb:9: warning: loading in progress, circular require considered harmful - lib/prawn/font.rb
@kbrock
Copy link
Author

kbrock commented Mar 7, 2025

update:

  • rebased to ensure an easy merge.

Thanks for the ping @radwo
I too hope this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Circular require warning in prawn 2.5.0
2 participants