Skip to content

Add new song select beatmap rankings section #32533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Mar 23, 2025

This branch in its current state does not hook up the rankings section with actual score fetching backend yet. I've used #32494 temporarily during my own testing and also to record the preview video below. I've left the code necessary to consume the components by the linked PR commented, so that if the PR goes in then attaching it to the components here is simple.

Preview:

CleanShot.2025-03-22.at.00.18.53-converted.mp4

CleanShot 2025-03-22 at 23 20 49

@peppy
Copy link
Member

peppy commented Apr 8, 2025

Closing this PR as un-reviewable due to chained PRs with unclear dependencies.

For changes of this size, it's nigh impossible to review on a per-PR basis. Some PRs in the sequence are very unclear on why they "depend" on the previous PR. There are hundreds of commits but individual commits are not meaningful.

#32673 -> #32480 -> #32496 -> #32533 -> #32715

will (attempt) review of #32715 alone

@peppy peppy closed this Apr 8, 2025
@peppy peppy self-requested a review April 10, 2025 12:07
@frenzibyte frenzibyte deleted the song-select-v2-wedges-rankings branch April 12, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants