-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add new song select beatmap rankings section #32533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces animation clutter.
3 tasks
This was referenced Apr 8, 2025
Closing this PR as un-reviewable due to chained PRs with unclear dependencies. For changes of this size, it's nigh impossible to review on a per-PR basis. Some PRs in the sequence are very unclear on why they "depend" on the previous PR. There are hundreds of commits but individual commits are not meaningful. #32673 -> #32480 -> #32496 -> #32533 -> #32715 will (attempt) review of #32715 alone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch in its current state does not hook up the rankings section with actual score fetching backend yet. I've used #32494 temporarily during my own testing and also to record the preview video below. I've left the code necessary to consume the components by the linked PR commented, so that if the PR goes in then attaching it to the components here is simple.
Preview:
CleanShot.2025-03-22.at.00.18.53-converted.mp4