-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more functionality to right clicking in the chat window #32446
Conversation
I noticed this while testing, but don't see this as the end of the world. Using the I've added documentation around this and renamed some variable to hopefully make things more explicit. |
Friend presences do update in real-time, so at least adding a check will eliminate some cases where the button should appear but doesn’t, and vice versa. |
I'm not too sure what you're saying. I don't see how we can check against both. In the case a friend is offline it's going to return a |
Can we just... not check the online flag at all in any capacity? I feel like while suboptimal, it's better what this currently is going to likely be which is state being frozen at the point of login more or less. |
Sounds good, have removed. |
I may have worded it poorly, what I meant is just checking the MetadataClient for the user presence. if (user.IsOnline || metadataClient?.GetPresence(user.OnlineID) != null) 2025-03-19.08-19-44.mp4 |
@GAMIS65 you're not understanding what you're being told. checking |
Based off of what was requested in #32423
Implements a button to both spectate and invite to multiplayer lobby.
Spectate
https://github.com/user-attachments/assets/d0858736-9ed0-4f49-9ab4-5cfd333579a0
Invite to Lobby
https://github.com/user-attachments/assets/8d4148e2-6a5f-48e7-9cb2-add112fa3173
Code is basically just slightly modified copy/paste from
UserPanel.cs