Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor crashing if beatmap does not have a mode explicitly specified in the .osu #32442

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Mar 18, 2025

Closes #32440.

Probably another "regression" from #32315.

Trying very hard not to type out any hyperbolic rants here.

bdach added 2 commits March 18, 2025 12:02
…ied in the `.osu`

Closes ppy#32440.

Probably another "regression" from
ppy#32315.

Trying very hard not to type out any hyperbolic rants here.
@bdach bdach added area:beatmap-parsing .osu file format parsing area:editor type:reliability next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Mar 18, 2025
@bdach bdach requested a review from a team March 18, 2025 11:09
@bdach bdach self-assigned this Mar 18, 2025
@peppy peppy merged commit 4957ea5 into ppy:master Mar 18, 2025
10 checks passed
@bdach bdach deleted the im-tired branch March 19, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS type:reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very old beatmaps cannot be edited
2 participants