Fix multiplayer join errors potentially not being logged #32436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get this isn't the specific path fixed, but since it was mentioned in the OP I checked on this as well. Feels a bit raw.. |
|
Gonna guess dev hasn't been redeployed with #32299 |
|
ahh right, missed that one. |
peppy
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32398
The changes to
MultiplayerLoungeSubScreenare a red-herring - that path of the condition is not taken in 99.99% of cases, the changes there are only best case to reduce potential double-logging. I don't think that change should be important to review/discuss.The actual fix is the
LoungeSubScreenchange. Basically, the callback is used by the password popover to display a local message. But, if the error is not related to a passworded room, then the message would just disappear into the ethers.