Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag add request using wrong method #32415

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fix tag add request using wrong method #32415

merged 1 commit into from
Mar 17, 2025
+1 −1

Conversation

peppy
Copy link
Member

@peppy peppy commented Mar 17, 2025

oop

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Mar 17, 2025
smoogipoo
smoogipoo approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laravel's apiResource maps controller.update to PUT | PATCH so this looks fine to me.

@smoogipoo smoogipoo requested a review from bdach March 17, 2025 05:05
bdach
bdach approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i get for not wanting to spend another 15 minutes testing the original change full stack i guess. i love laravel's implicit conventions for everything

@bdach bdach merged commit a74b2db into ppy:master Mar 17, 2025
7 of 10 checks passed
@peppy
Copy link
Member Author

peppy commented Mar 17, 2025

agree it's very much a gotcha and i also "love" it.

@umuod umuod mentioned this pull request Mar 17, 2025
Closed
@peppy peppy deleted the fix-tag-adding branch March 18, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppy @smoogipoo @bdach