Improve handling for top-anchored judgement positions in osu!mania #32344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If providing a video in the OP, please make it a simple before / after or just after. I struggle to follow a video where you're coding in it (where the code doesn't match the PR's diff). |
peppy
reviewed
Mar 13, 2025
| Origin = Anchor.Centre; | ||
| // Extend the dimensions of this drawable to the entire parenting container. | ||
| // This allows skin implementations (i.e. LegacyManiaJudgementPiece) to freely choose the anchor based on skin settings. | ||
| Anchor = Anchor.TopLeft; |
There was a problem hiding this comment.
Very unsure about this, but let's see how it plays out I guess...
It's just a short method of loading a skin with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
CleanShot.2025-03-12.at.03.05.46-converted.mp4
(notice when given
ScorePosition = 100, the judgement is now anchored to the top rather than the bottom)