Ensure qualified beatmaps are never looked up on stale cache source #32329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
the
area:beatmap-change-tracking
bdach
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Other than the blocker below I guess in principle this works.
One thing I'll remark on is that with this if you try and import a qualified beatmap while not being logged in it won't get an online status at all, which I guess is a foregone conclusion anyway given the online.db changes have rolled out, and it's a long-standing concern anyway (really need to make the lookup endpoint accessible without auth at some point)
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
bdach
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As i proposed here.
I experimented with nuking the local database immediately, but this seems cleaner and less prone to fail.