Fix edge cases which allow very short slider placement in editor #32328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
commented
Mar 11, 2025
| /// <summary> | ||
| /// Should be used to check whether placement can continue after a user editor operation. | ||
| /// </summary> | ||
| public bool HasValidLengthForPlacement => Precision.DefinitelyBigger(Distance, 0, 1); |
There was a problem hiding this comment.
I've renamed this to better show that it's only used in the editor. I wanted to make these changes without affecting parsing logic to keep things simple, and this property felt a bit iffy with its previous name and location.
bdach
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could lead to a game crash.
Closes #32295 (comment).
Addresses both dragging for more repeats on the slider in the provided
.osufile, as well as getting into that state in the first place.osu.2025-03-11.at.07.19.17.mp4