Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust timeline placement display #32319

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

64ArthurAraujo
Copy link
Contributor

Closes #32317

Increases the darkness so its now distinguishable

before
after

@peppy
Copy link
Member

peppy commented Mar 11, 2025

Maybe try opacity? Dimming looks wrong to me.

@SchiavoAnto
Copy link
Contributor

I don't think dimming looks that good, I tried showing the yellow border (which the blueprint already has) and think it looks better because the blueprint you move on the gameplay field has the border too. Maybe combined with opacity like peppy said?

@peppy peppy self-requested a review March 11, 2025 09:20
@peppy peppy changed the title Make HitObject placement blueprint darker Adjust timeline placement display Mar 11, 2025
@peppy peppy changed the title Adjust timeline placement display Adjust timeline placement display Mar 11, 2025
@peppy
Copy link
Member

peppy commented Mar 11, 2025

Adjusted to use border. A bit hacky code but I don't think it's worth overthinking for now.

@peppy peppy requested a review from bdach March 11, 2025 09:36
@bdach
Copy link
Collaborator

bdach commented Mar 11, 2025

If I were to anticipate what the next complaint is going to be, it'd be that the border doesn't work well on yellow-orange-ish hues, e.g.:

osu_2025-03-11_11-28-41

There is a difference on the screenshot above but it's very subtle.

I guess we can try this and observe user feedback?

@SchiavoAnto
Copy link
Contributor

While creating the other PR I also tried with other colors, for example white, and with a very subtle glow around it but was not sure of how it looked...
image
image

@64ArthurAraujo
Copy link
Contributor Author

64ArthurAraujo commented Mar 11, 2025

I guess we can try this and observe user feedback?

i think a simple Alpha = 0.75f would be better, i tested it before the dim and it looked fine
image

@peppy
Copy link
Member

peppy commented Mar 11, 2025

Alpha looks bad without a buffered container for compositing, so I didn't consider that path.

@bdach
Copy link
Collaborator

bdach commented Mar 11, 2025

@peppy shall I take your response above as acknowledgement of the discussion and a proposal to try this diff as is anyway? bit confused as to what the path forward here is

@peppy
Copy link
Member

peppy commented Mar 11, 2025

yep happy to go with what's here for now. until someone else complains

@bdach bdach merged commit 3710d0e into ppy:master Mar 11, 2025
7 of 10 checks passed
@64ArthurAraujo 64ArthurAraujo deleted the editor-darker-placement-blueprint branch March 11, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to distinguish yet-to-be-placed objects from already playced ones at timeline
5 participants