Ensure that star rating reprocessing does not incur online lookup requests #32273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests Yesterday after the lazer release there was a bit of a spike in the number of osu-web requests pointed at `/api/v2/beatmaps/lookup` specifically. The most likely reason for this is that prior to this commit, the star rating recalculation was fully performed by the `BeatmapUpdater.Process()` flow. This process does full metadata lookups, and while it *will* attempt to use the local `online.db` metadata cache, it *will* also fall back to API requests if the local metadata fetch fails. While that means that the local cache likely saved us from a doomsday scenario here, it *also* is the case that all of that metadata lookup stuff is *entirely unnecessary* when wanting to just update star ratings. Therefore, this splits out only the part relevant to star ratings as a separate background process, so that it can run completely locally.
peppy
previously approved these changes
Mar 10, 2025
|
Seems fine. If we're doing changes like that I've also pushed in 6b1472b which pulls the actual diffcalc out of the realm transaction. I'm not sure this is going to do anything for issues like #32255, though; on one of the huge databases I have locally I get a huge lagspike on intro and it's seemingly caused by the resetting of the star ratings (which take multiple seconds) rather than the subsequent diffcalc itself. |
peppy
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday after the lazer release there was a bit of a spike in the number of osu-web requests pointed at
/api/v2/beatmaps/lookupspecifically. The most likely reason for this is that prior to this commit, the star rating recalculation was fully performed by theBeatmapUpdater.Process()flow.This process does full metadata lookups, and while it will attempt to use the local
online.dbmetadata cache, it will also fall back to API requests if the local metadata fetch fails. While that means that the local cache likely saved us from a doomsday scenario here, it also is the case that all of that metadata lookup stuff is entirely unnecessary when wanting to just update star ratings.Therefore, this splits out only the part relevant to star ratings as a separate background process, so that it can run completely locally.