Allow kiai/star-fountain activation SFX to be skinnable #32267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Mar 7, 2025
| @@ -40,7 +48,7 @@ private void load(AudioManager audio) | |||
| }, | |||
| }; | |||
|
|
|||
| sample = audio.Samples.Get(@"Gameplay/fountain-shoot"); | |||
| sample = skin.GetSample(new SampleInfo(@"Gameplay/fountain-shoot")); | |||
There was a problem hiding this comment.
Hmm, this either needs to use SkinnableSound or handle the ISkinSource.SouceChanged flow..
Preferably the former since everything is setup correctly for samples in that class (note that it will need to be added to the draw hierarchy to work correctly).
peppy
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fountain-shootsample)