Localise skin rename/export/delete buttons in settings #32243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joehuu
reviewed
Mar 5, 2025
|
The added "delete" string wasn't removed. |
|
Sorry, forgot. Should be ok now. |
Joehuu
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
I saw this when looking why the buttons weren't localised: #31220 (comment)
But this is only adding one string now, and it may be used somewhere else in the future (e.g. a "rename" in a context menu), so approving.
smoogipoo
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds localisation support to the Rename, Export, and Delete buttons in the skin section of the settings menu.
I have added the localisation strings in
CommonStrings.csinstead ofSkinSettingsStrings.csbecause I think "Rename" and "Delete" are so general that they can be used in other places, following "Export" which was already there.