Add "discard unsaved changes" operation to beatmap editor

[bdach]

2025-03-05.14-23-38.mp4

Apparently useful in modding workflows when you want to test out a few different variants of a thing.

Re-uses Ctrl-L binding from stable. Some folks may argue that the dialog makes the hotkey pointless, but I really do want to protect users from accidental data loss, and also if you want to power through it quickly, you can hit the 1 key when the dialog shows, which will bypass the hold-to-activate period (which wasn't intentional, but so many people want a bypass at this point that we're probably keeping that behaviour for power users).

---

[smoogipoo]

Did you intend to localise this one?

[bdach]

Editor needs a full localisation pass anyway (including figuring out how to make localisations of ruleset strings, by the way) so if I'm honest I kinda don't care about localisation there that much.

[smoogipoo]

I only asked because you added a localisable string for it.

[peppy]

I've updated to use the new localisation.

I have one remaining concern: I'd expect this to be under the file menu, not edit (historical reasoning):

diff --git a/osu.Game/Screens/Edit/Editor.cs b/osu.Game/Screens/Edit/Editor.cs
index 80e1a656de..f56380a34d 100644
--- a/osu.Game/Screens/Edit/Editor.cs
+++ b/osu.Game/Screens/Edit/Editor.cs
@@ -392,10 +392,6 @@ private void load(OsuConfigManager config)
                                         {
                                             undoMenuItem = new EditorMenuItem(CommonStrings.Undo, MenuItemType.Standard, Undo) { Hotkey = new Hotkey(PlatformAction.Undo) },
                                             redoMenuItem = new EditorMenuItem(CommonStrings.Redo, MenuItemType.Standard, Redo) { Hotkey = new Hotkey(PlatformAction.Redo) },
-                                            discardChangesMenuItem = new EditorMenuItem(GlobalActionKeyBindingStrings.EditorDiscardUnsavedChanges, MenuItemType.Destructive, DiscardUnsavedChanges)
-                                            {
-                                                Hotkey = new Hotkey(GlobalAction.EditorDiscardUnsavedChanges)
-                                            },
                                             new OsuMenuItemSpacer(),
                                             cutMenuItem = new EditorMenuItem(CommonStrings.Cut, MenuItemType.Standard, Cut) { Hotkey = new Hotkey(PlatformAction.Cut) },
                                             copyMenuItem = new EditorMenuItem(CommonStrings.Copy, MenuItemType.Standard, Copy) { Hotkey = new Hotkey(PlatformAction.Copy) },
@@ -1273,6 +1269,11 @@ private IEnumerable<MenuItem> createFileMenuItems()
             saveRelatedMenuItems.Add(save);
             yield return save;
 
+            yield return discardChangesMenuItem = new EditorMenuItem(GlobalActionKeyBindingStrings.EditorDiscardUnsavedChanges, MenuItemType.Destructive, DiscardUnsavedChanges)
+            {
+                Hotkey = new Hotkey(GlobalAction.EditorDiscardUnsavedChanges)
+            };
+
             if (RuntimeInfo.OS != RuntimeInfo.Platform.Android)
             {
                 var export = createExportMenu();

[bdach]

I added it to edit because I wanted it to be next to undo/redo as related, but 🤷

[smoogipoo]

Lgtm otherwise