-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current beatmap info to window title #32222
Add current beatmap info to window title #32222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are relevant. Host.Window
is null on headless tests.
Not sure about the following text being in the titlebar while the intro is playing out: Feels kinda weird and is exposing our implementation details of "the intro music is a beatmap actually". Maybe this should be done in some other way to prevent this sort of stuff. Possibly hooked up to the Need @peppy or @smoogipoo opinion on this. |
This reverts commit 14b5c0b. This is not necessary as the title update is already scheduled on the correct thread by the framework.
I'm assuming all the "special" maps have their |
I forgot that this exists to be honest. We can use that too if it works, probably simpler that way. |
Should only show during gameplay like stable. |
It shows beatmap metadata during gameplay, spectating, and watching replays but shows beatmap filename during editng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I have tested it on Linux, both on Wayland and X11, using SDL2 and SDL3, and it's working fine for me.
It might need more changes as I'm still not super familiar with the codebase, but I thought I'd create a PR and continue here.
Closes #32188