Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current beatmap info to window title #32222

Merged
merged 9 commits into from
Mar 6, 2025

Conversation

zihadmahiuddin
Copy link
Contributor

I have tested it on Linux, both on Wayland and X11, using SDL2 and SDL3, and it's working fine for me.
It might need more changes as I'm still not super familiar with the codebase, but I thought I'd create a PR and continue here.

Closes #32188

Copy link
Member

@Susko3 Susko3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are relevant. Host.Window is null on headless tests.

@bdach
Copy link
Collaborator

bdach commented Mar 5, 2025

Not sure about the following text being in the titlebar while the intro is playing out:

1741183072

Feels kinda weird and is exposing our implementation details of "the intro music is a beatmap actually". Maybe this should be done in some other way to prevent this sort of stuff. Possibly hooked up to the UserActivity system that we use for online and presence and so on?

Need @peppy or @smoogipoo opinion on this.

This reverts commit 14b5c0b.
This is not necessary as the title update is already scheduled on the correct thread by the framework.
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 5, 2025
@zihadmahiuddin
Copy link
Contributor Author

I'm assuming all the "special" maps have their BeatmapSetInfo.Protected set to true, in that case maybe those can be ignored. It would be the easy fix but I don't know if it's the right one.
For now, I'm experimenting with UserActivity in another branch, would OsuGame still be the right place to track the current UserActivity?

@bdach
Copy link
Collaborator

bdach commented Mar 5, 2025

I'm assuming all the "special" maps have their BeatmapSetInfo.Protected set to true

I forgot that this exists to be honest. We can use that too if it works, probably simpler that way.

@peppy
Copy link
Member

peppy commented Mar 5, 2025

Should only show during gameplay like stable.

It shows beatmap metadata during gameplay, spectating, and watching replays but shows beatmap filename during editng
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 5, 2025
smoogipoo
smoogipoo previously approved these changes Mar 6, 2025
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@smoogipoo smoogipoo requested a review from peppy March 6, 2025 03:49
@smoogipoo smoogipoo merged commit 97749e1 into ppy:master Mar 6, 2025
8 of 10 checks passed
@zihadmahiuddin zihadmahiuddin deleted the feat/window-title-current-map branch March 6, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Song title no longer in application title in Lazer (Windows)
5 participants