-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taskbar flashing when a multiplayer game is starting #32180
Conversation
@@ -142,6 +145,7 @@ protected override void StartGameplay() | |||
|
|||
if (client.LocalUser?.State == MultiplayerUserState.Loaded) | |||
{ | |||
game?.Window?.Flash(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be done in PlayerLoader
for a bit more time. The beatmap you showcased in the video is not really a good example because it has an intro (it shows a skip button on solo play). Without an intro, circles would show like a second after the flash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're probably right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just unsure how to implement this feature in a way where it only happened when loading into a multiplayer lobby, would it be fine if it just flashed whenever a map begins loading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultiplayerPlayerLoader
? If you weren't able to find this I have a few concerns though 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! That's what I get for trying to write code so late 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM maybe. Putting it in OnEntering()
is another place to consider (arguably more correct as it will be the same time the host presses the button to start the match).
Leaving others to decide.
I think I would probably put this in That said, I feel like it may be better to delay this until my refactor/rewrite of this screen to separate it from |
Not sure if I'd expect it to trigger on spectating 🤔 debatable for sure. |
In that case, I suppose this is fine to go as-is. It's isolated from my changes like this. |
I'm not sure if this was implemented in stable, but it's something that I feel is missing from multiplayer right now. I normally tab out of the lobby while waiting for people to ready up, and so having the indicator makes it easier to do that without the match starting without me.
2025-03-02.00-35-31.mp4