Fix settings control not visible because of previous search #32135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes `SettingsPanel`'s `SearchTextBox` protected from private so that `SettingsOverlay` can access it.
bdach
requested changes
Feb 28, 2025
bdach
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SettingsOverlayis shown as a result of callingShowAtControland there was something written in the settings search text box previously, it wouldn't show the target control if it doesn't match the query. (#32122)This PR makes it so the search text box is cleared before showing the settings.
It also makes
SettingsPanel'sSearchTextBoxprotected from private so thatSettingsOverlaycan access it. But I think that should be fine.I couldn't find any tests for
SettingsOverlay, only forSettingsPanelso I didn't add any tests for this. Let me know if I should add tests.Closes #32122