Limit number of allowed beatmap combo colours to 8 #32110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Feb 26, 2025
Comment on lines
+131
to
+133
| bool isCombo = pair.Key.StartsWith(@"Combo", StringComparison.Ordinal) | ||
| && int.TryParse(pair.Key[5..], out int comboIndex) | ||
| && comboIndex >= 1 && comboIndex <= MAX_COMBO_COLOUR_COUNT; |
There was a problem hiding this comment.
By the way, I am choosing not to notice that none of this parsing logic actually checks that the combo colours are in order and just parses them sequentially without examining the number in the key, because it's very annoying to handle and it's been the case before I came here. Until someone invariably reports that as an issue, that is.
peppy
force-pushed
the
combo-colour-count-limit
branch
from
d305153 to
0b45377
Compare
|
Wasn't a huge fan of the button disappearing, so made it disable instead @bdach please double check. |
peppy
approved these changes
Feb 27, 2025
|
Changes look fine, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31936.
Matching stable.