Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alt + mousewheel volume adjustment on result screens #32075

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

Gennadiyev
Copy link

A small patch to fix #31860 and match the behaviors with stable.

untitled.mp4

Most of the code is copy-pasted from SongSelect.cs:

// we want to block plain scrolls on the left side so that they don't scroll the carousel,
// but also we *don't* want to handle scrolls when they're combined with keyboard modifiers
// as those will usually correspond to other interactions like adjusting volume.
protected override bool OnScroll(ScrollEvent e) => !e.ControlPressed && !e.AltPressed && !e.ShiftPressed && !e.SuperPressed;

The inserted GlobalScrollAdjustVolume resides in a VerticalScrollContainer, and I do not know whether it is a good practice or not.

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just waiting for the day that this is added back on every single screen in the game.

@peppy peppy merged commit c9a492a into ppy:master Mar 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to adjust volume in result screen
4 participants