Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beatmap overlay to show all guest mappers #31970

Merged
merged 7 commits into from
Mar 17, 2025
Merged

Update beatmap overlay to show all guest mappers #31970

merged 7 commits into from
Mar 17, 2025
+128 −85

Conversation

cdwcgt
Copy link
Contributor

@cdwcgt cdwcgt commented Feb 20, 2025 •
edited
Loading

before after
image image

There will be display problems when the number of guest mapper is very large, but I can't think of a way to solve it. see in test when 20 guest in a diff

@Joehuu Joehuu self-requested a review February 20, 2025 21:43
@Joehuu
Copy link
Member

Joehuu commented Feb 21, 2025

There will be display problems when the number of guest mapper is very large, but I can't think of a way to solve it.

The solution would be to replace the entire FillFlowContainer that has version, guestMapperContainer, etc. to a LinkFlowContainer and use Clear() and Add{Text|Link} and TextAnchor to bottom left to align the smaller text. The problem is that TextAnchor doesn't work as intended, see #8580.

@Joehuu Joehuu removed their request for review February 21, 2025 23:39
@cdwcgt
Copy link
Contributor Author

cdwcgt commented Feb 23, 2025 •
edited
Loading

I think I tried this method and gave up because it was not ideal.
This may be the reason mentioned above.
I want to know if this problem is best solved in this PR or wait until later

In addition to the issues listed above, we will also lose the animation of the star text
Because there is no way to control the part of text in LinkFlowContianer separately (Or maybe I just don't know?)

this is what I have but not commit
image

bdach added a commit to bdach/osu-framework that referenced this pull request Mar 4, 2025
@bdach @HiddenNode
Fix TextFlowContainer not laying text out properly on some `TextAnc…
6c76fb8 
…hor` settings

- Closes ppy#5084
- Closes ppy#5499
- Closes ppy#2073
- Closes ppy/osu#8580
- Supersedes / closes ppy#5507

You might ask why I'm bothering to try this now. Well, this came up when
I wanted to use text flow for BSS purposes (and forced me to hack around
it), and came up again in ppy/osu#31970, and I'm
sick of it.

The actual fix is taken verbatim from
ppy#5507, it's just restructured
using the idea of a single nested flow taken from
ppy#5507 (comment).

As such:

Co-authored-by: HiddenNode <101936124+HiddenNode@users.noreply.github.com>
@bdach bdach mentioned this pull request Mar 4, 2025
Merged
bdach added a commit to bdach/osu-framework that referenced this pull request Mar 4, 2025
@bdach @HiddenNode
Fix TextFlowContainer not laying text out properly on some `TextAnc…
2ed2351 
…hor` settings

- Closes ppy#5084
- Closes ppy#5499
- Closes ppy#2073
- Closes ppy/osu#8580
- Supersedes / closes ppy#5507

You might ask why I'm bothering to try this now. Well, this came up when
I wanted to use text flow for BSS purposes (and forced me to hack around
it), and came up again in ppy/osu#31970, and I'm
sick of it.

The actual fix is taken verbatim from
ppy#5507, it's just restructured
using the idea of a single nested flow taken from
ppy#5507 (comment).

As such:

Co-authored-by: HiddenNode <101936124+HiddenNode@users.noreply.github.com>
bdach added a commit to bdach/osu-framework that referenced this pull request Mar 5, 2025
@bdach @HiddenNode
Fix TextFlowContainer not laying text out properly on some `TextAnc…
f2179bc 
…hor` settings

- Closes ppy#5084
- Closes ppy#5499
- Closes ppy#2073
- Closes ppy/osu#8580
- Supersedes / closes ppy#5507

You might ask why I'm bothering to try this now. Well, this came up when
I wanted to use text flow for BSS purposes (and forced me to hack around
it), and came up again in ppy/osu#31970, and I'm
sick of it.

The actual fix is taken verbatim from
ppy#5507, it's just restructured
using the idea of a single nested flow taken from
ppy#5507 (comment).

As such:

Co-authored-by: HiddenNode <101936124+HiddenNode@users.noreply.github.com>
bdach added a commit to bdach/osu-framework that referenced this pull request Mar 5, 2025
@bdach @HiddenNode
Fix TextFlowContainer not laying text out properly on some `TextAnc…
045749d 
…hor` settings

- Closes ppy#5084
- Closes ppy#5499
- Closes ppy#2073
- Closes ppy/osu#8580
- Supersedes / closes ppy#5507

You might ask why I'm bothering to try this now. Well, this came up when
I wanted to use text flow for BSS purposes (and forced me to hack around
it), and came up again in ppy/osu#31970, and I'm
sick of it.

The actual fix is taken verbatim from
ppy#5507, it's just restructured
using the idea of a single nested flow taken from
ppy#5507 (comment).

As such:

Co-authored-by: HiddenNode <101936124+HiddenNode@users.noreply.github.com>
@bdach bdach self-requested a review March 17, 2025 11:26
@bdach
Copy link
Collaborator

bdach commented Mar 17, 2025

Text flow has been fixed framework side so I've applied that solution. I don't think the slight fade out of the star rating text matters when the rest of the text transforms immediately so it's neither here or there really.

@bdach bdach merged commit aa6dfa0 into ppy:master Mar 17, 2025
7 of 10 checks passed
@bdach bdach changed the title Update guest difficulty display to consistent with the web page Update beatmap overlay to show all guest mappers Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:overlay-beatmap size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdwcgt @Joehuu @bdach