Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SelectedRoom from online play tests #31867

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Feb 12, 2025

It's one of those "magic" abstractions that I'd prefer to not exist.

In multiplayer tests, if a room is required (generally the case), you can put a:

public override void SetUpSteps()
{
    base.SetUpSteps();
    JoinDefaultRoom();
}

See for example: https://github.com/ppy/osu/blob/205d6ecffbc989d75c1a32e53a29a9342b88c175/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerQueueList.cs

@peppy peppy self-requested a review March 4, 2025 07:00
@peppy
Copy link
Member

peppy commented Mar 4, 2025

@smoogipoo there's one conflict with a newly added test TestChangeSettingsButtonVisibleForHost could you have a check on that?

@peppy peppy enabled auto-merge March 4, 2025 10:21
@peppy peppy disabled auto-merge March 4, 2025 12:56
@peppy peppy merged commit 0d3e66f into ppy:master Mar 4, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants