Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scale animation when holding editor "test" button #31854

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Feb 11, 2025

Closes #31852.

@bdach bdach self-requested a review February 11, 2025 08:29
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scale animation was very intentionally there because I recall you at one point mentioning something about how lack of scaling made buttons feel like not buttons at all and thus was bad UX and internalised that as a rule, but I guess given this comes from you directly then either something has changed, this is a special exception, or I misinterpreted or misremembered something.

@peppy
Copy link
Member Author

peppy commented Feb 11, 2025

see the issue thread video - scale can't exist when it de-aligns the button from the thing behind it (that is "feels" attached to). if there was padding between the button and the bar then the scale remaining would be fine.

@bdach
Copy link
Collaborator

bdach commented Feb 11, 2025

I'm aware of why this is being done. You could say there might have been other ways to fix it, like extending the timeline background to cover behind the button. Either way, not really fussed about it.

@bdach bdach merged commit 58d0401 into ppy:master Feb 11, 2025
8 of 9 checks passed
@peppy
Copy link
Member Author

peppy commented Feb 11, 2025

it would still need padding and rounded corners in my eyes

@peppy peppy deleted the editor-test-button-scale-disable branch February 12, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants