Add invalidation on draw size change in beatmap carousel v2 #31817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching old implementation.
smoogipoo
reviewed
Feb 6, 2025
| @@ -678,6 +679,15 @@ private static void expirePanelImmediately(Drawable panel) | |||
| carouselPanel.Expanded.Value = false; | |||
| } | |||
|
|
|||
| protected override bool OnInvalidate(Invalidation invalidation, InvalidationSource source) | |||
There was a problem hiding this comment.
Is there a reason you've used this instead of a LayoutValue? Primary concern is you're not returning true here with means the drawnode MAY not get invalidated if the stars line up correctly and the base call doesn't do it for you, which is an easy thing to miss by using this method.
There was a problem hiding this comment.
hmm, it's copy-pasted from old carousel. can try using the newer structure.
There was a problem hiding this comment.
It's a non blocker anyway, was more interested than anything.
smoogipoo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching old implementation. Required because
DrawHeight(and thereforevisibleHalfHeight) changes on aspect ratio change.Before:
osu.Game.Tests.2025-02-06.at.08.49.37.mp4
After:
osu.Game.Tests.2025-02-06.at.08.48.58.mp4