Fix depth ordering in new carousel not being relative to selected item #31776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably would have asked to get the full depth implemented (ie giving individual panel types the ability to be depth'd differently) but let's get this in as a starting point. |
peppy
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #31774. This makes it match lazer behaviour.
Another thing that should eventually be done is that the depth ordering should also consider the type of carousel item, so that difficulty panels are always displayed behind set panels, otherwise they may appear on top of set panels during motion (i.e. when expanding/collapsing a set).
Before (with #31774 checked out):
After (with #31774 checked out):