Fix distance snap time part ceasing to work when grid snap is also active #31737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #31655 (comment).
Before:
2025-01-30.14-45-36.mp4
After:
2025-01-30.14-46-27.mp4
Things to pay attention to on videos above: indicator whether Ctrl/Shift is pressed down below, and what happens to the start time of the object on the timeline up above.
Will attempt test coverage on request. It's a bit annoying to add coverage of snapping in an actual composer scenario (need to set up some credible pre-calculated scenario with snapping involved and hardcode expected coordinates).