Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and display user-friendly errors regarding corrupted audio files #31697

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 27, 2025

Addresses lack of user feedback as indicated by and closes #31693.

bdach added 2 commits January 27, 2025 10:25

Verified

This commit was signed with the committer’s verified signature.
bdach Bartłomiej Dach
Addresses lack of user feedback as indicated by
ppy#31693.

Verified

This commit was signed with the committer’s verified signature.
bdach Bartłomiej Dach
…atmap

Bit ugly, but appears to work in practice...
@smoogipoo smoogipoo merged commit a863230 into ppy:master Jan 28, 2025
8 of 10 checks passed
@bdach bdach deleted the corrupt-mp3s-should-not-crash-game branch January 28, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging & Dropping .mp3 returns error
2 participants