Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor absolute scrolling at song select #31535

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 16, 2025

This is a bit of a catch-all fix up while implementing this in the new carousel.

  • Adds support for absolute scrolling to carousel v2
  • User can now choose a custom binding instead of right mouse if you wish
  • Removes most of the handling code from OsuScrollContainer
  • Removes the setting. This can now be disabled by unbinding the key. Note that this changes the default to have it as right mouse button. This is an intentional change – I believe this functionality should be on by default as it's beneficial to most users.

@smoogipoo smoogipoo merged commit 88829d5 into ppy:master Jan 17, 2025
8 of 9 checks passed
@peppy peppy deleted the beatmap-carousel-v2-right-click-scroll branch January 17, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants