Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NVika tool to 4.0.0 #31534

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Bump NVika tool to 4.0.0 #31534

merged 1 commit into from
Jan 16, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 16, 2025

Code quality CI runs have suddenly started failing out of nowhere:

In classic github fashion, they began rolling out another runner change wherein ubuntu-latest has started meaning ubuntu-24.04 rather than ubuntu-22.04. ubuntu-24.04 no longer has .NET 6 bundled.

Therefore, upgrade NVika to 4.0.0 because that version is compatible with .NET 8.

See https://github.com/bdach/osu/actions/runs/12808006553/job/35709785355#step:10:1 for proof that this does anything.

Code quality CI runs have suddenly started failing out of nowhere:

- Passing run: https://github.com/ppy/osu/actions/runs/12806242929/job/35704267944#step:10:1
- Failing run: https://github.com/ppy/osu/actions/runs/12807108792/job/35707131634#step:10:1

In classic github fashion, they began rolling out another runner change
wherein `ubuntu-latest` has started meaning `ubuntu-24.04` rather than
`ubuntu-22.04`. `ubuntu-24.04` no longer has .NET 6 bundled.

Therefore, upgrade NVika to 4.0.0 because that version is compatible
with .NET 8.
@bdach bdach self-assigned this Jan 16, 2025
bdach added a commit to bdach/osu-framework that referenced this pull request Jan 16, 2025
bdach added a commit to bdach/osu-queue-score-statistics that referenced this pull request Jan 16, 2025
bdach added a commit to bdach/osu-difficulty-calculator that referenced this pull request Jan 16, 2025
bdach added a commit to bdach/osu-tools that referenced this pull request Jan 16, 2025
@peppy peppy enabled auto-merge January 16, 2025 12:11
@bdach bdach disabled auto-merge January 16, 2025 13:04
@bdach bdach merged commit 70c81b1 into ppy:master Jan 16, 2025
8 of 10 checks passed
@bdach bdach deleted the nvika-dotnet-8 branch January 16, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants