Implement spectator list display #31526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First step for ppy#22087 - Supersedes / closes ppy#22795 Roughly uses design shown in ppy#22795 (comment) with some modifications to better fit everything else, and some customisation options so it can fit better on other skins.
1 task
3 tasks
Removed autosize duration stuff because it looks weird when the list is shown from scratch where users are already fully populated in it.
|
I pushed test fixes and some visual changes. @bdach please confirm you're okay with the new commits. |
peppy
previously approved these changes
Jan 16, 2025
…ith spectators already present Noticed by accident, but if the `BindCollectionChanged()` callback fires immediately in `LoadComplete()` when set up and there are spectators present already, then `NewStartingIndex` in the related event is -1: https://github.com/dotnet/runtime/blob/b03f83de362f7168c94daa2f4b192959abefe366/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs#L84-L92 which kinda breaks the math introducing off-by-ones and in result causes 11 items to be displayed together rather than 10.
|
New commits look okay 👍 In passing, thanks to the "last name gradiented" change, I noticed that I inadvertently did an off-by-one in the collection change callback; see 81f5450 for more info. Nothing to add other than that. |
peppy
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-01-15.14-19-23.mp4
Roughly uses design shown in #22795 (comment) with some modifications to better fit everything else, and some customisation options so it can fit better on other skins.