Add support for CursorTrailRotate skin command
#31519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
reviewed
Jan 15, 2025
| protected override void LoadComplete() | ||
| { | ||
| base.LoadComplete(); | ||
| loadCompleteTime = Parent!.Clock.CurrentTime; // using parent's clock since our is overridden |
There was a problem hiding this comment.
I dunno about this... And the Source.Parent lookup in the DrawNode too. If you just want to synchronise the rotation, can't there be some component orchestrating something along the lines of CursorTrail.PartRotation = Cursor.Rotation in an Update() somewhere?
There was a problem hiding this comment.
Yeah, looks much more robust now 😅
|
Not sure about these CodeFactor issues. Like does it want me to add parenthesis in mentioned places? |
|
It's fine to ignore those CodeFactor issues, makes sense as it is. |
smoogipoo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31482
Preview: https://streamable.com/1g3bh8