Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update game ScrollContainer usage in line with framework changes #31474

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 10, 2025

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 14, 2025
@bdach
Copy link
Collaborator

bdach commented Jan 14, 2025

There was a PR for the same textbox adjustments done in 904a08a, and it was #30495, and it has extra changes this diff doesn't, so I'm merging it in here.

SelectAllOnFocus = true;
}

protected override bool CanAddCharacter(char character) => char.IsAsciiDigit(character);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -31 to -33
protected override bool AllowClipboardExport => false;

protected override bool AllowWordNavigation => false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdach bdach enabled auto-merge January 14, 2025 08:58
@bdach bdach disabled auto-merge January 14, 2025 09:56
@bdach bdach merged commit 459577c into ppy:master Jan 14, 2025
8 of 10 checks passed
@peppy peppy deleted the scroll-container-double-precision branch January 14, 2025 11:49
andy840119 added a commit to andy840119/karaoke that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants