Fix slider end judgements appearing at incorrect locations when mods that flip playfield are active #26885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#26867. Reverts 882f490 and ce643aa. The applied optimisation may have been valid as long as it was constrained to `Slider`. But it is not, as `SliderTailCircle` stores a local copy of the object position. And as the commit message of ce643aa states, this could be bypassed by some pretty hacky delegation from `SliderTailCircle.Position` to the slider, but it'd also be pretty hacky because it would make flows like `PositionBindable` break down. Long-term solution is to probably remove bindables from hitobjects.
bdach
added
ruleset/osu!
area:gameplay
next release
|
I'm fine with reverting my fix for now. The long-term solution to remove bindables from hitobjects. That would probably mean having the editor and |
peppy
approved these changes
Jan 31, 2024
|
I have come to learn that this regression likely affected diffcalc/pp too and as such we're going to have to check if it did (it's not impossible it didn't if the databased beatmap attributes weren't updated since the regression), and if it did, wipe or recalc pp for at least all HR lazer scores. cc @ppy/team-client @ppy/osu-pp-committee |
|
I believe the consensus reached is that master and live-sr are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The applied optimisation may have been valid as long as it was constrained to
Slider. But it is not, asSliderTailCirclestores a local copy of the object position. And as the commit message of ce643aa states, this could be bypassed by some pretty hacky delegation fromSliderTailCircle.Positionto the slider, but it'd also be pretty hacky because it would make flows likePositionBindablebreak down.Long-term solution is to probably remove bindables from hitobjects.
cc @OliBomby