Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hit target position in osu!taiko to always match stable #26634

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jan 19, 2024

The offset was ballparked / taken from #26615. Comparison between stable and lazer on classic skin:

CleanShot.2024-01-20.at.02.02.41.mp4

(used my screenshot utility to ensure the gap between the input drum and the hit target is constant)

Preview on non-classic skins:

triangles argon
CleanShot 2024-01-20 at 02 01 21 CleanShot 2024-01-20 at 02 01 01

@OliBomby
Copy link
Contributor

I tried this with a few skins imported from stable and it looks good! Here is an example of a skin where the input drum curves around the target position:

osu!_w5qgRdo2Y5

This was broken on master where the distance between the elements would be too big.

@pull-request-size pull-request-size bot added size/S and removed size/L labels Jan 26, 2024
@peppy peppy self-requested a review January 26, 2024 08:55
@peppy peppy merged commit 1c22dbc into ppy:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants