Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change S rank to require no miss #26630

Merged
merged 24 commits into from
Jan 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c8521b4
Change S rank to require no miss
peppy Jan 19, 2024
bb1eab5
Update test in line with new rank definitions always being applied
peppy Jan 22, 2024
4eba3b5
Move `BackgroundDataStoreProcessor` to better namespace
peppy Jan 22, 2024
644e7d6
Add migration
peppy Jan 22, 2024
83f9118
Adjust results screen to handle S->A rank adjustment when misses are …
peppy Jan 22, 2024
5bae907
Merge branch 'master' into s-rank-change
bdach Jan 22, 2024
cb8ec48
Make `RankFromScore()`'s dictionary param readonly
bdach Jan 22, 2024
20ed7e1
Fix back-to-front conditional in taiko processor
bdach Jan 22, 2024
45dc9de
Remove remnant of old implementation of showing "A due to misses"
bdach Jan 22, 2024
81a0266
Adjust existing test to fail
bdach Jan 17, 2024
3f31593
Add another failing tests covering recomputation of ranks
bdach Jan 22, 2024
aa8eee0
Move maximum statistics population to `LegacyScoreDecoder`
bdach Jan 17, 2024
2958631
Use lazer accuracy & rank implementations across the board
bdach Jan 17, 2024
db48494
Unify legacy total score / accuracy / rank recomputation flows
bdach Jan 22, 2024
217cbf6
Remove superfluous recomputation of accuracy
bdach Jan 22, 2024
cdd6e71
Remove legacy computation of accuracy & ranks
bdach Jan 22, 2024
d53fb5a
Update assertions to match expected behaviour
bdach Jan 22, 2024
24be6d9
Expand xmldoc
bdach Jan 22, 2024
fdd499a
Fix rank background processing not working (and not bumping score ver…
bdach Jan 22, 2024
4d253eb
Remove redundant assertion
bdach Jan 22, 2024
0cf9067
Apply more correct visual offset adjustment
peppy Jan 23, 2024
cb87d6c
Move transferal of `LegacyTotalScore` back to original spot
bdach Jan 23, 2024
0b5be3c
Remove outdated test
bdach Jan 23, 2024
6c169e3
Do not reprocess ranks for custom rulesets
bdach Jan 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions osu.Game/Scoring/Legacy/LegacyScoreDecoder.cs
Original file line number Diff line number Diff line change
@@ -187,8 +187,6 @@ internal static void PopulateMaximumStatistics(ScoreInfo score, WorkingBeatmap w
var rulesetInstance = ruleset.CreateInstance();
var scoreProcessor = rulesetInstance.CreateScoreProcessor();

Debug.Assert(rulesetInstance != null);

// Populate the maximum statistics.
HitResult maxBasicResult = rulesetInstance.GetHitResults()
.Select(h => h.result)