Fix background dim occasionally getting in a bad state when exiting gameplay #26544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Jan 15, 2024
osu.Game/Screens/Play/Player.cs
Outdated
| b.IgnoreUserSettings.Value = true; | ||
|
|
||
| b.IsBreakTime.UnbindFrom(breakTracker.IsBreakTime); | ||
| b.IsBreakTime.Value = true; |
There was a problem hiding this comment.
As far as I can tell, this is backwards, and judging from the OP:
Can confirm that this was the issue by changing the
= falsethat I added to an= true
it looks like a leftover change from that confirmation.
bdach
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26344.
Can confirm that this was the issue by changing the
= falsethat I added to an= true, will reproduce what was seen in the video.