Revert "Keep editor in frame stable mode when possible" #26521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
added
area:editor
next release
peppy
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling frame stability in editor makes things like mania editor absolutely dog in performance, since after placing an object, the entire replay is changed from under the editor, which leads it to try to frame-stable-catch-up from start of gameplay, spend 5 frames utterly failing to do so, and then hit the catch-up limit and spend the 6th frame frame-stable playing back the rest of the missing gameplay, in the mean time doing this to the update thread:
So let's just revisit as unfeasible for now.