-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wiki main page not displaying custom layout #26441
Conversation
Joehuu
commented
Jan 8, 2024
- Regressed in Fix wiki link path inconsistencies #26378
Before | After |
---|---|
![]() |
![]() |
Can you explain what is happening here? What's with the casing changes? How did you decide which casing is "right"? Why does one place do |
It was to bring in line the rest of the casing consistency to tests and fix
Wiki pages/paths are sentence-cased.
Custom page layout strings are the lowercased path string, hopefully. There are two layouts (the only custom one being
Thought it was fine that tests have hardcoded things. The tests just copy the API json output. |