Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix score conversion incorrectly assuming zero combo score in certain cases #26440

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 8, 2024

This fell out during work on #26405.

Turns out the assumption of "if combo score plus bonus score is zero then relax / autopilot must have been on" from #26082 is overreaching. https://osu.ppy.sh/beatmapsets/675779#osu/1431549 is a beatmap which has a difficultyPeppyStars of zero (0), which means that it doesn't get any combo score (and also happens to have no bonus score), which means that going by

double comboProgress = maximumComboPortion > 0 ? currentComboPortion / maximumComboPortion : 1;

there's not really anything smart to do other than give it the full combo portion of score for free. And yes this probably helps some bad scores too much, but also makes SSes actually worth 960k score rather than 96% of accuracy portion.

This affects all rulesets, but judging from the osu! spreadsheet that I ran (https://docs.google.com/spreadsheets/d/1PmtF9maLl2WAc9BGDx02yv_YqU-2N9wftr0JOZk0m_k/edit#gid=469242467), there is only one beatmap affected by this.

I intentionally am not bumping LegacyScoreEncoder.LATEST_VERSION because I already have 2 other pulls open that touch it. It'll fall in there too is what I'm thinking.

@peppy peppy merged commit 743411d into ppy:master Jan 9, 2024
@bdach bdach deleted the incorrect-combo-proportion branch January 9, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants