Fix score conversion incorrectly assuming zero combo score in certain cases #26440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fell out during work on #26405.
Turns out the assumption of "if combo score plus bonus score is zero then relax / autopilot must have been on" from #26082 is overreaching. https://osu.ppy.sh/beatmapsets/675779#osu/1431549 is a beatmap which has a
difficultyPeppyStars
of zero (0), which means that it doesn't get any combo score (and also happens to have no bonus score), which means that going byosu/osu.Game/Rulesets/Scoring/ScoreProcessor.cs
Line 369 in 70ba5dd
there's not really anything smart to do other than give it the full combo portion of score for free. And yes this probably helps some bad scores too much, but also makes SSes actually worth 960k score rather than 96% of accuracy portion.
This affects all rulesets, but judging from the osu! spreadsheet that I ran (https://docs.google.com/spreadsheets/d/1PmtF9maLl2WAc9BGDx02yv_YqU-2N9wftr0JOZk0m_k/edit#gid=469242467), there is only one beatmap affected by this.
I intentionally am not bumping
LegacyScoreEncoder.LATEST_VERSION
because I already have 2 other pulls open that touch it. It'll fall in there too is what I'm thinking.