Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scores from song select leaderboard when leaving the screen #26410

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 6, 2024

Noticed they would disappear-then-appear after visiting the ranking screen. Which feels very weird.

@peppy peppy force-pushed the ranking-leaderboard-whiz branch from 5f07ae2 to d3710f0 Compare January 6, 2024 11:53
@bdach bdach self-requested a review January 8, 2024 10:39
@bdach
Copy link
Collaborator

bdach commented Jan 8, 2024

The transition is still pretty jarring on local scores but can agree online leaderboards look better, so let's just go with it for now...

@bdach bdach merged commit 991c6d2 into ppy:master Jan 8, 2024
@peppy peppy deleted the ranking-leaderboard-whiz branch January 12, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants