Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in #26357

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 3, 2024

/// Whether the audio playback rate should be validated.
/// Mostly disabled for tests.
/// </summary>
internal bool ShouldValidatePlaybackRate { get; init; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing an = true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed it is

@peppy peppy merged commit 8b8f795 into ppy:master Jan 3, 2024
@bdach bdach deleted the score-submission-intermittent-fail branch January 3, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants