Implement automatic suggestion of global audio offset based on last plays #26169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look into fixing tests if barebones concept is evaluated as valid. |
peppy
reviewed
Dec 28, 2023
osu.Game/Overlays/Settings/Sections/Audio/SessionAverageHitErrorTracker.cs
Outdated
Show resolved
Hide resolved
osu.Game/Overlays/Settings/Sections/Audio/AudioOffsetAdjustControl.cs
Outdated
Show resolved
Hide resolved
|
I've added a couple of commits of my own, please check over them too. Generally this looks great. |
peppy
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. PRing very early to see if this'll even stick as a UI concept & code execution.
2023-12-27.21-15-57.mp4
I'm gonna let the video above speak for itself as to what this is. If it's not clear what it is from the above video then I think I have failed.
This control takes the place of the existing audio offset slider in game settings.
Note that ceci n'est pas un offset wizard. It's supposed to be a crude something to be in place by next year while the work on the real offset wizard can be postponed just a little bit longer.
I don't much like the fact that I had to introduce yet another thing in
OsuGameBasefor this but I don't see many other options. I'd have put a list inSessionStatics, but that is annoying (due to semantics, you can't just put a list, as it won't fire value change callbacks if you add stuff to it; there's no way to jam aBindableListin there; so what you'd have to do is just spam.ToArray()calls such that the callbacks fire).