Hide HoldForMenuButton on non-touch devices
#26128
Conversation
Disable the enter animation and fully hide until cursor is near on non-touch devices.
| @@ -99,9 +111,11 @@ protected override void Update() | |||
| Alpha = 1; | |||
| else | |||
| { | |||
| float minAlpha = AutoHide.Value ? .001f : .07f; | |||
There was a problem hiding this comment.
I tried allowing the alpha to clamp to 0, (and enabling AlwaysPresent on the container), however ran into issues with testing as the interpolation below seemed to never reach a fixed value.
osu.Game/Screens/Play/HUDOverlay.cs
Outdated
| @@ -158,7 +158,7 @@ public HUDOverlay([CanBeNull] DrawableRuleset drawableRuleset, IReadOnlyList<Mod | |||
| Direction = FillDirection.Vertical, | |||
| Children = new Drawable[] | |||
| { | |||
| HoldToQuit = CreateHoldForMenuButton(), | |||
| HoldToQuit = CreateHoldForMenuButton(touchDevice: mods.Any(m => m is ModTouchDevice)), | |||
There was a problem hiding this comment.
Rather than doing this, use SessionStatics from within the class, don't pass anything in.
osu/osu.Game/Screens/Play/PlayerTouchInputDetector.cs
Lines 24 to 29 in 63a0ea5
There was a problem hiding this comment.
Please don't self resolve issues. This isn't even fixed.
There was a problem hiding this comment.
I misunderstood it as "dont pass anything to CreateHoldForMenuButton", I assume you meant inject it from within HoldForMenuButton?
Use SessionStatics to supply touch device data and invert the autohide parameter to better fit the supplied Bindable.
|
I've taken part of what you did here and PR'd it separately with some simplification: #26542. |
As per this discussion in the discord, this PR changes the
HoldForMenuButtonto never appear on non-touch devices until the cursor is nearby, and on touch devices it will retain the pop-in animation, fading out to always be slightly visible. Since this component is redundant on devices on devices with a keyboard and hardcoded regardless it should be at least hidden.