Add classic skin sprites for slider tick and slider end misses #26117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
ruleset/osu!
next release
peppy
force-pushed
the
add-slider-tick-end-miss-sprites
branch
from
91f4cd1 to
b1d994b
Compare
bdach
previously requested changes
Dec 25, 2023
bdach
dismissed
their stale review
seems okay, just waiting for the resources package now
bdach
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design feedback was taken in
#generalon discord.A lot of complaints asking for disable on the new elements. Mostly because it was confusing to just downscale the normal miss.
Now they get their own sprites. And as a result it's skinnable for the people that are really adverse to change. You can skin via
slidertickmiss@2x.pngandsliderendmiss@2x.png.CleanShot.2023-12-25.at.08.12.17.mp4
CleanShot.2023-12-25.at.08.13.40.mp4