Add control to allow changing offset from gameplay

[peppy]

Intended to be a very rough implementation, because I'm not supposed to be spending time on these things right now (although arguably, this is in the project sooo...)

In the future, I would see the PlayerLoader settings being moved into gameplay and having a better display method. I'd also hope to load the current score as reference so the user could get immediate feedback on their adjustment, but HitEvents are currently not populated in realtime.

Also yes, it is intended that this displays initially if the offset is non-zero. Stable also does this to inform the user that there's a local override.

• Note that I haven't tested the alt+key support, as my keyboard layers don't allow that combination >_<.

Closes #25007.

---

This behaves how you'd expect it to coming from stable. It's intended to be a very quick implementation just to get the functionality back, and will improve in the future. Controls are configurable but default to +/-. Hold Alt to get more precise control.

CleanShot.2023-12-23.at.12.01.47.mp4

[bdach]

Alt-key support doesn't work as written because of

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Lines 21 to 22 in fde0276

	public GlobalActionContainer(OsuGameBase? game)
	: base(matchingMode: KeyCombinationMatchingMode.Modifiers)

(it would have to be KeyCombinationMatchingMode.Any to work, but that would presumably break everything).

[bdach]

I'm also not sure how to feel about the fact that one can do this with this implementation:

2023-12-23.16-06-37.mp4

Seems flimsy in terms of e.g. mobile especially.

[bdach]

as above

[peppy]

I'm also not sure how to feel about the fact that one can do this with this implementation

I kinda made it with this in mind, but didn't bother to make it use the same "stay visible while hovered".

Do you think it would be better to just hide the slider for now?

[peppy]

Alt-key support doesn't work as written because of

Figured this was likely going to happen. Any bright ideas? Shall we just make it 1 ms for now by default, and add more support later?

[bdach]

I kinda made it with this in mind, but didn't bother to make it use the same "stay visible while hovered".

I was referring more to the part wherein you can move it about much more freely than via the keyboard hotkey. This makes it an abuse vector / game balance issue in my head.

Slider should either be gone or not be interactable if you ask me.

Figured this was likely going to happen. Any bright ideas? Shall we just make it 1 ms for now by default, and add more support later?

Either that or separate actions I guess? Separate actions is kind of ugly though.

[peppy]

This makes it an abuse vector / game balance issue in my head.

Right, I forgot to add the limitations which stable has, will do that.