Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perfect mod not failing with special judgements #26036

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Fix perfect mod not failing with special judgements #26036

merged 5 commits into from
Dec 22, 2023

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Dec 22, 2023 •
edited by bdach
Loading

@smoogipoo smoogipoo changed the title Fix perfect mod special judgements Fix perfect mod not failing with special judgements Dec 22, 2023
@peppy peppy self-requested a review December 22, 2023 05:46
@bdach bdach mentioned this pull request Dec 22, 2023
Closed
@bdach bdach self-requested a review December 22, 2023 07:17
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 22, 2023
bdach
bdach reviewed Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to perfect look correct, but not sure about changes to sudden death

@peppy peppy merged commit 7e09164 into ppy:master Dec 22, 2023
@peppy peppy removed their request for review December 22, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:mods ruleset/osu!mania ruleset/osu! size/L type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perfect mod permits dropped slider ends Perfect mod fails if player gets Great judgement in osu!mania
3 participants
@smoogipoo @bdach @peppy