-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning of local scores #25998
Conversation
4b5fbe6
to
2f833f1
Compare
For any potential future usage
2f833f1
to
a4baa0a
Compare
osu.Game/Scoring/ScoreInfo.cs
Outdated
/// The version of the client this score was set using. | ||
/// Sourced from <see cref="OsuGameBase.Version"/> at the point of score submission. | ||
/// </summary> | ||
public string Version { get; set; } = string.Empty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess probably the only question I'd have here is - do we wanna put this in replays too (and decode it from there on import)? We can probably put this in LegacyReplaySoloScoreInfo
with practically zero effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah. I didn't realise this was so low effort, if so then let's do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on stream I've also renamed the property to @peppy would appreciate double-check of changes. Importantly, if you're going to run this, remove |
For any potential future usage
Minimal implementation as to not spend too much time, just want to get this in place in case we need it.